Open
Conversation
jmdacruz
force-pushed
the
bug-dotted-date-with-time
branch
from
b7b743b to
0583fb6
Compare
klondikedragon
added a commit
to itlightning/dateparse
that referenced
this pull request
Dec 15, 2023
Fix for this bug mentioned in araddon#134 Also, the other cases mentioned in this PR are not valid formats, so add them to the TestParseErrors test, to document that this is expected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I created a test that shows what I'm seeing: Parsing "2014-02-13 00:00:00" and "2014.02.13" return equivalent time representations, but "2014.02.13 00:00:00" fails to parse. This PR is not meant to be merged yet, since the tests I added are failing due to these issue. If this is a valid issue, we can figure out the fix.